OF-2505: BOSH: add back-pressure to network IO when processing can't keep up #2109
Conversation
|
I have already cherry-picked this to the 4.7 branch, as I needed a Bamboo build. If this PR is rejected, or receives changes, those changes should also be applied to the 4.7 branch! |
…keep up For BOSH and websocket connections, this commit introduces a new feature (disabled by default) that allows Openfire to be configured to apply 'back pressure' that could be useful in a scenario where the network IO thread pool is outpacing the processing thread pool. By enabling the feature using `xmpp.httpbind.worker.backpressure-enabled` (and setting the queue to a limited value with `xmpp.httpbind.worker.queue-capacity`, the queuing of new tasks by the network IO thread pool blocks when the queue is at capacity.
guusdk
force-pushed
the
OF-2505_BOSH-backpressure
branch
from
e272048
to
cfb56eb
Compare
|
@guusdk Did you get any feedback on your 4.7 branch build with this change included? |
|
I did - although it seemed to work as designed, the net effect of the change wasn't what we were hoping for in the very specific load test that was being used. We seem to be running into race conditions / locking scenario. There still might be merit in this change, even if we're not going to use it in the specific use-case that I had in mind. |
|
I think this at the very least needs a modification. The enum |
|
Converted to draft whilst it awaits changes. |
For BOSH and websocket connections, this commit introduces a new feature (disabled by default) that allows Openfire to be configured to apply 'back pressure' that could be useful in a scenario where the network IO thread pool is outpacing the processing thread pool.
By enabling the feature using
xmpp.httpbind.worker.backpressure-enabled(and setting the queue to a limited value withxmpp.httpbind.worker.queue-capacity), the queuing of new tasks by the network IO thread pool blocks when the queue is at capacity.