Large refactoring of view code backed by adding tests for sqlalchemy model classes #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
depend on SQLAlchey 0.8.0 in requirements.txt, add first Integration test, remove unused context from views.ToDoViews, apply this change in README as well
…stability of TodoItem, add several tests inserting TodoItems, all tests pass, update version in setup.py to 1.1, move model-related code from scripts.initializedb.main to create_dummy_content
…dels to hide model implementation details, better utilize model relationships to enable application features, add more tests, all tests pass
refactor code that filters todos by tag into user model, add __repr__ to model classes 'Tag' and 'TodoItem' to support working with IPython, added IPython session as docstring to next test class
up big large existing view that handles everything, form views use SQLAlchemy models to change application state, move todoitem.due_date timezone conversion into existing SQLAlchemy domain models - TDB in todogrid, add new XHR route for todos to support AJAX-based loading of todo into modal task form, change URL generation to use route configuration, revisited inclusion of deform JS/CSS dependencies into global template, include pyramid add-ons from paster configuration files, all tests pass
… be installed inside TRAVIS CI
because it fits to the existing two use-cases.
|
Good job @saschagottfried |
ToDoPyramid is now running on OpenShift using a Free Plan
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Claytron,
I love TodoPyramid for its idea & look and almost always refer to this example, listed on the offical pyramid tutorials page, when explaining basic pyramid principles to others. I wanted to apply many ideas to my own projects. Coming from Plone I wanted to learn sqlalchemy and deform. Thus I started exploring the implementation of almost all concepts within ToDoPyramid. This way I created a lot of Gitub issues and started hacking. Having tests for the model kept me almost safe. It is now different from the one you created, but these changes are almost transparent to a single user. I need to invest more time into sqlalchemy docs. I think now is a good moment to inform you about my work. I think the project as a whole can now communicate important concepts of pyramid application programming a bit cleaner, mostly because I refactored the big large single view class into several parts and increased readability of the source code by separating concerns. It is my first pull request on GitHub and the first thing I added to Travis CI. Please consider pulling my changes into the project or tell me your idea about publishing it to pyramid beginners.