fix(inputs.mysql): MariaDB example to include mariadb_dialect (#16159) #16160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…data#16159) Also use MariaDB names and healthcheck to ensure running before telegraf started.
|
Thanks so much for the pull request! |
telegraf-tiger
bot
added
area/mysql
fix
|
!signed-cla |
srebhan
reviewed
Nov 7, 2024
There was a problem hiding this comment.
@grooverdan I would really like to get rid of this dev subdir as we do have integration tests instead of this manual testing... Do you think there is anything that is worth preserving?
|
Sure, can you point me towards the integration tests? |
|
Basically every test in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Docker-compose example for inputs.mysql for the MariaDB didn't include mariadb_dialect = true. As all maintained versions of MariaDB are 10.5 it seemed prudent to include.
Also it was possible for telegraf to start before MariaDB was ready. Use the healthcheck mariadb has to ensure that docker compose orders this correctly.
The mariadb container can take straight command line arguments and this will pass though to the mariadb server (mariadbd).
Checklist
Related issues
resolves #16159