-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(extension): posthog lace version lw-8778 #665
base: main
Are you sure you want to change the base?
Conversation
apps/browser-extension-wallet/src/providers/PostHogClientProvider/client/PostHogClient.ts
Outdated
Show resolved
Hide resolved
apps/browser-extension-wallet/src/providers/PostHogClientProvider/client/PostHogClient.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have left a few comments - especially about the instance interface returned from the PostHogClient
class constructor
Allure report
smokeTests: ✅ test report for 6823d018
|
@tommayeliog is this PR still relevant? if not please consider closing it and deleting the branch :) |
Checklist
Proposed solution
Explain how does this PR solves the problem stated in JIRA ticket.
You can also enumerate different alternatives considered while approaching this task.
Testing
Describe here, how the new implementation can be tested.
Provide link or briefly describe User Acceptance Criteria/Tests that need to be met
Screenshots
Attach screenshots here if implementation involves some UI changes
Allure report
allure-report-publisher
generated test report!smokeTests: ❌ test report for dc2c5ebf