Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(extension): posthog lace version lw-8778 #665

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

tommayeliog
Copy link
Contributor

@tommayeliog tommayeliog commented Oct 25, 2023

Checklist


Proposed solution

Explain how does this PR solves the problem stated in JIRA ticket.
You can also enumerate different alternatives considered while approaching this task.

Testing

Describe here, how the new implementation can be tested.
Provide link or briefly describe User Acceptance Criteria/Tests that need to be met

Screenshots

Attach screenshots here if implementation involves some UI changes


Allure report

allure-report-publisher generated test report!

smokeTests: ❌ test report for dc2c5ebf

passed failed skipped flaky total result
Total 31 1 0 0 32

@tommayeliog tommayeliog requested a review from a team as a code owner October 25, 2023 14:26
@github-actions github-actions bot added the browser Changes to the browser application. label Oct 25, 2023
Copy link
Member

@DominikGuzei DominikGuzei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have left a few comments - especially about the instance interface returned from the PostHogClient class constructor

Copy link

github-actions bot commented Nov 8, 2023

Allure report

allure-report-publisher generated test report!

smokeTests: ✅ test report for 6823d018

passed failed skipped flaky total result
Total 31 0 0 0 31

@DominikGuzei
Copy link
Member

@tommayeliog is this PR still relevant? if not please consider closing it and deleting the branch :)

@rhyslbw rhyslbw marked this pull request as draft September 13, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
browser Changes to the browser application.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants