-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support private channels #165
Conversation
CC @gjabell |
6debed9
to
2615c91
Compare
Codecov Report
@@ Coverage Diff @@
## master #165 +/- ##
=========================================
- Coverage 9.84% 8.99% -0.86%
=========================================
Files 9 9
Lines 1026 1090 +64
=========================================
- Hits 101 98 -3
- Misses 921 987 +66
- Partials 4 5 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
TODO before merging this PR: now the channel names in the chanlist don't show have the prefix anymore (e.g. |
2615c91
to
dc05eaf
Compare
94c9a57
to
3a623e8
Compare
Tested on multiple teams on public and private channels, and on IM. Still not working in threads |
174be66
to
3ef0097
Compare
Now also tested on threads in public and private channels |
3ef0097
to
6753597
Compare
Messages and threads to self are not yet supported. See #166 |
Will merge this PR tomorrow if no other issue appears |
6753597
to
86bf5e7
Compare
the last update fixes IMs that I broke accidentally in this PR. So now the test matrix is:
|
86bf5e7
to
b32b461
Compare
Updated readme with feature matrix |
This patch adds support to private channels. Previously, private channels were read-only, while now it's bidirectional like public channels and IMs. This required a refactoring of the channels API, and a few bug fixes. Now anything channel-related goes through the Channel and Channels structures, and should not use the Slack conversations API directly anymore. Signed-off-by: Andrea Barberio <[email protected]>
b32b461
to
71a4684
Compare
Merged! This one took quite a lot of work, but I'm happy with the result (hopefully I won't take those words back :D ). Next is to add some serious testing, since any change to this project is hard to validate. |
This patch adds support to private channels. Previously, private
channels were read-only, while now it's bidirectional like public
channels and IMs.
This required a refactoring of the channels API, and a few bug fixes.
Now anything channel-related goes through the Channel and Channels
structures, and should not use the Slack conversations API directly
anymore.
Signed-off-by: Andrea Barberio [email protected]