Fix Issues with verifyIdToken #58
Open
+85
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sky-rabbit-cnc
added a commit
to sky-rabbit-cnc/dart_firebase_admin
that referenced
this pull request
Nov 3, 2024
labrom
reviewed
Nov 7, 2024
| try { | ||
| verifyJwtSignature( |
There was a problem hiding this comment.
I would recommend maybe keeping the verifyJwtSignature function call, and modifying the function to only catch JWTExpiredException, since the handling of JWTExpiredException is the same in both verifiers.
labrom
reviewed
Nov 7, 2024
| @internal | ||
| factory TokenProvider.fromMap(Map<dynamic, dynamic> map) { | ||
| return TokenProvider( | ||
| identities: map['identities']! as Map<String, Object?>, |
There was a problem hiding this comment.
Since behavior changed here, would you mind writing a test?
|
I made the changes do we need more tests for the emulator related changes? |
labrom
reviewed
Nov 8, 2024
| 'phone_number': 'mock-phone-number', | ||
| 'picture': 'mock-picture', | ||
| 'sub': 'mock-sub', | ||
| 'uid': 'mock-sub', |
There was a problem hiding this comment.
The doc says that uid isn't actually present in the token, and this field is just a convenience that takes its value from sub. How about removing this line then?
|
I believe this should also fix #56, would you mind updating the description? |
|
Done |
|
Awesome, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
fixes #57
fixes #56
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]).I have updated the
CHANGELOG.mdof the relevant packages.Changelog files must be edited under the form:
If this contains new features or behavior changes,
I have updated the documentation to match those changes.