Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: improve app's bootstrap HTML metadata #2168

Merged
merged 6 commits into from
Apr 19, 2024
Merged

fix: improve app's bootstrap HTML metadata #2168

merged 6 commits into from
Apr 19, 2024

Conversation

jphastings
Copy link
Contributor

Some simple changes to remove defaults from the CreateReactApp origins:

  • Improves the HTML title to more specifically match this app (vs. other IPFS produced sites)
  • Adds a meta description (pulled from the Github repo)
  • Adds an IPFS theme colour in HTML meta
  • Adds canonical link to bootstrap HTML

@jphastings
Improve app's bootstrap HTML metadata
569221a 
Some simple changes to remove defaults from the CreateReactApp origins:

- Improves the HTML title to more specifically match this app (vs. other IPFS produced sites)
- Adds a meta description (pulled from the Github repo)
- Adds an IPFS theme colour in HTML meta
- Adds canonical link to bootstrap HTML
@jphastings jphastings requested a review from a team as a code owner October 22, 2023 16:23
@welcome
Copy link

welcome bot commented Oct 22, 2023

Thank you for submitting this PR!
A maintainer will be here shortly to review it.
We are super grateful, but we are also overloaded! Help us by making sure that:

  • The context for this PR is clear, with relevant discussion, decisions
    and stakeholders linked/mentioned.

  • Your contribution itself is clear (code comments, self-review for the
    rest) and in its best form. Follow the code contribution
    guidelines
    if they apply.

Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
Next steps:

  • A maintainer will triage and assign priority to this PR, commenting on
    any missing things and potentially assigning a reviewer for high
    priority items.

  • The PR gets reviews, discussed and approvals as needed.

  • The PR is merged by maintainers when it has been approved and comments addressed.

We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution.
We are very grateful for your contribution!

@SgtPooki
Copy link
Member

Thanks for this @jphastings, unfortunately, our pinning CI is currently broken due to Estuary sunsetting their pinning service and our ipfs-cluster intermittently failing on pinning this content. I am tracking some work to address this in #2161

@jphastings
Copy link
Contributor Author

Thanks for keeping me up to date, let me know if there's anything you'd like me to do!

SgtPooki
SgtPooki approved these changes Apr 18, 2024
View reviewed changes
public/index.html Outdated Show resolved Hide resolved
@SgtPooki SgtPooki changed the title Improve app's bootstrap HTML metadata fix: Improve app's bootstrap HTML metadata Apr 18, 2024
@SgtPooki SgtPooki changed the title fix: Improve app's bootstrap HTML metadata fix: improve app's bootstrap HTML metadata Apr 18, 2024
lidel
lidel approved these changes Apr 18, 2024
View reviewed changes
Copy link
Member

@lidel lidel left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, small suggestion inline but also fine to disregard.

public/index.html Outdated Show resolved Hide resolved
public/index.html Show resolved Hide resolved
@lidel lidel mentioned this pull request Apr 18, 2024
Draft
3 tasks
@SgtPooki SgtPooki merged commit 9c10520 into ipfs:main Apr 19, 2024
22 checks passed
@jphastings jphastings deleted the patch-1 branch April 22, 2024 22:17
ipfs-gui-bot pushed a commit that referenced this pull request Aug 12, 2024
@semantic-release-bot
chore(release): 4.3.0 [skip ci]
27bea32 
## [4.3.0](v4.2.1...v4.3.0) (2024-08-12)

 CID `bafybeihatzsgposbr3hrngo42yckdyqcc56yean2rynnwpzxstvdlphxf4`

 ---

### Features

* **remotepins:** add Functionland Fula ([#2242](#2242)) ([b998f3c](b998f3c))

### Bug Fixes

* improve app's bootstrap HTML metadata ([#2168](#2168)) ([9c10520](9c10520))
* loading empty content ([#2237](#2237)) ([e81d132](e81d132))

### Trivial Changes

* **ci:** dnslink update on .tech tld ([222053a](222053a))
* **ci:** stop updating webui.ipfs.io ([5b06c3f](5b06c3f))
* **deps:** bump actions/checkout from 3.6.0 to 4.1.2 ([#2213](#2213)) ([d028190](d028190))
* **deps:** bump actions/github-script from 6 to 7 ([#2197](#2197)) ([7342cfa](7342cfa))
* **deps:** bump axios, @storybook/test-runner, bundlesize and wait-on ([#2215](#2215)) ([fbbe5ff](fbbe5ff))
* **deps:** bump ip from 1.1.8 to 1.1.9 ([#2211](#2211)) ([d73e798](d73e798))
* **deps:** bump stefanzweifel/git-auto-commit-action from 4.16.0 to 5.0.1 ([#2222](#2222)) ([c6159c3](c6159c3))
* pull transifex translations ([#2220](#2220)) ([35f8aae](35f8aae))
@ipfs-gui-bot
Copy link
Collaborator

🎉 This PR is included in version 4.3.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@yahorshumski yahorshumski mentioned this pull request Aug 23, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SgtPooki SgtPooki SgtPooki approved these changes

@lidel lidel lidel approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jphastings @SgtPooki @ipfs-gui-bot @lidel