Yet more IREEGPUAttrs cleanup: drop get{A,B,C}SingleSubgroupLayout methods
#19169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Benoit Jacob <[email protected]>
bjacob
force-pushed
the
drop-getXsinglesubgrouplayout
branch
4 times, most recently
from
77e3459
to
48fea31
Compare
Signed-off-by: Benoit Jacob <[email protected]>
bjacob
force-pushed
the
drop-getXsinglesubgrouplayout
branch
from
48fea31
to
835eace
Compare
bjacob
requested review from
MaheshRavishankar,
qedawkins,
kuhar,
Groverkss and
antiagainst
as code owners
krzysz00
reviewed
Nov 16, 2024
| @@ -69,7 +69,7 @@ static bool is_AMD_WMMA(MMAIntrinsic intrinsic) { | |||
|
|
|||
| static int64_t getIntrinsicSubgroupSize(MMAIntrinsic intrinsic) { | |||
| // Not using Wave64 at all at the moment, so the only place where the | |||
| // subgroup size is CDNA* architectures. | |||
| // subgroup size is 64 is CDNA* architectures. | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These methods existed before we added the unified
getSingleSubgroupLayouttaking aMMAFragmentargument. Now they can go away. Actually polymorphic callers, which motivated this being an interface method, are taken care of by a new overload ofgetSingleSubgroupLayouttaking aMMAInterfaceAttr.