-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
set container of kubectl to 'uncaptured' #1664
base: master
Are you sure you want to change the base?
set container of kubectl to 'uncaptured' #1664
Conversation
😊 Welcome @silenceshell! This is either your first contribution to the Istio tools repo, or it's been You can learn more about the Istio working groups, code of conduct, and contributing guidelines Thanks for contributing! Courtesy of your friendly welcome wagon. |
303e710
to
fdfcaea
Compare
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think what we actually want is to control this with kubectl.kubernetes.io/default-container
This is a good choice, my only concern is backward compatible, as |
Same problem here, |
When trying the perf/benchmark, I met a problem below.
The pods
fortioclient-54894c5758-htdgl
default container iscaptured
, so the kubectl command will try to run fortio incaptured
container.Here is the log.
Maybe it is better to specify the container to run by kubectl, thus we won't exec fortio in wrong container.