Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2] Update versions in README #6206

Merged
merged 3 commits into from
Nov 13, 2024

Conversation

yurishkuro
Copy link
Member

Which problem is this PR solving?

  • README was referring to 1.59 version as example

Description of the changes

  • Update to refer to 2.0.0
  • Clean-up

How was this change tested?

  • CI

@yurishkuro yurishkuro requested a review from a team as a code owner November 13, 2024 21:23
@dosubot dosubot bot added the v2 label Nov 13, 2024
Copy link

codecov bot commented Nov 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.47%. Comparing base (6e695b3) to head (bb0e1ae).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6206      +/-   ##
==========================================
- Coverage   96.49%   96.47%   -0.02%     
==========================================
  Files         354      354              
  Lines       20127    20127              
==========================================
- Hits        19421    19418       -3     
- Misses        522      524       +2     
- Partials      184      185       +1     
Flag Coverage Δ
badger_v1 8.31% <ø> (ø)
badger_v2 1.67% <ø> (ø)
cassandra-4.x-v1 14.39% <ø> (ø)
cassandra-4.x-v2 1.61% <ø> (ø)
cassandra-5.x-v1 14.39% <ø> (ø)
cassandra-5.x-v2 1.61% <ø> (ø)
elasticsearch-6.x-v1 18.59% <ø> (-0.01%) ⬇️
elasticsearch-7.x-v1 18.68% <ø> (ø)
elasticsearch-8.x-v1 18.84% <ø> (-0.01%) ⬇️
elasticsearch-8.x-v2 1.66% <ø> (-0.02%) ⬇️
grpc_v1 9.48% <ø> (ø)
grpc_v2 7.00% <ø> (+<0.01%) ⬆️
kafka-v1 8.88% <ø> (ø)
kafka-v2 1.67% <ø> (ø)
memory_v2 1.66% <ø> (-0.02%) ⬇️
opensearch-1.x-v1 18.73% <ø> (ø)
opensearch-2.x-v1 18.73% <ø> (ø)
opensearch-2.x-v2 1.66% <ø> (ø)
tailsampling-processor 0.46% <ø> (ø)
unittests 95.38% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Yuri Shkuro <[email protected]>
Copy link
Collaborator

@mahadzaryab1 mahadzaryab1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a couple of questions

cmd/jaeger/README.md Outdated Show resolved Hide resolved
@@ -1,10 +1,8 @@
# jaeger

This is experimental Jaeger V2 based on OpenTelemetry collector.
Jaeger V2 based on OpenTelemetry collector.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we link the new blog post here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The other post is more technical. Ideally this should point to the docs instead of a blog post.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we want to do that in this PR?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not a particularly critical README. We do need to push more visibility though for v2, maybe in the main README.

scripts/build-hotrod-image.sh Show resolved Hide resolved
Signed-off-by: Yuri Shkuro <[email protected]>
@yurishkuro yurishkuro merged commit 61ad598 into jaegertracing:main Nov 13, 2024
50 checks passed
@yurishkuro yurishkuro deleted the update-v2-readme branch November 13, 2024 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants