-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v2] Update versions in README #6206
Conversation
Signed-off-by: Yuri Shkuro <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6206 +/- ##
==========================================
- Coverage 96.49% 96.47% -0.02%
==========================================
Files 354 354
Lines 20127 20127
==========================================
- Hits 19421 19418 -3
- Misses 522 524 +2
- Partials 184 185 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Yuri Shkuro <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a couple of questions
@@ -1,10 +1,8 @@ | |||
# jaeger | |||
|
|||
This is experimental Jaeger V2 based on OpenTelemetry collector. | |||
Jaeger V2 based on OpenTelemetry collector. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we link the new blog post here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The other post is more technical. Ideally this should point to the docs instead of a blog post.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we want to do that in this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not a particularly critical README. We do need to push more visibility though for v2, maybe in the main README.
Signed-off-by: Yuri Shkuro <[email protected]>
Which problem is this PR solving?
Description of the changes
How was this change tested?