Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement menu bar and menu for windows #167

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kodie
Copy link

@kodie kodie commented Apr 28, 2023

I added a menu bar and menus for windows. It might not be 100% but I think it's pretty damn close. 😃

In addition to the menu bar I also added a frame class for the window-body class to get smaller margins.

Screenshots:
Screen Shot 2023-04-28 at 9 41 45 AM
Screen Shot 2023-04-28 at 9 43 29 AM

Reference screenshot from Windows 98:
Screen Shot 2023-04-28 at 9 42 37 AM

@vercel
Copy link

vercel bot commented Apr 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
98css ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 28, 2023 2:53pm

@kodie
Copy link
Author

kodie commented Apr 28, 2023

Somewhat related: #38

@kodie
Copy link
Author

kodie commented Apr 28, 2023

I guess maybe the menu bar could have been its own component to be consistent with how it's done on win7.css? https://khang-nd.github.io/7.css/#menubar

idk let me know what you think, I can change it if needed.

@kodie
Copy link
Author

kodie commented Apr 28, 2023

Also the frame class I added could become the default and we could implement a has-space class to add the margin back like how win7.css does it: https://khang-nd.github.io/7.css/#window-body

Copy link

@firebellys firebellys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lg2m

@juanigaray
Copy link
Collaborator

This looks very good. I think that ideally the menu should open and then close on repeated clicks. Maybe a <details> element could work for that, but we'd have to check if we can make it look like a menu bar item.

@ippezshelby
Copy link

Make menu have multi-level capability as some menu items may have parent-child relationship

@909oce
Copy link

909oce commented Feb 24, 2024

sorry i might be really stupid but for some reason i cant get the menu buttons to actually do anything? im trying to use onclick which is what i use for my other buttons. am i missing something?

you can see my project for reference at https://909.wtf/

edit: using onmousedown works

@ammaraslam10
Copy link

When will this be merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants