-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI issue in the "tree view" #7216 #7253
Open
itsmevichu
wants to merge
12
commits into
jupyter:main
Choose a base branch
from
itsmevichu:ingore-tree-patterns
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtpio
reviewed
Feb 19, 2024
jtpio
reviewed
Mar 12, 2024
const [, , path] = matches; | ||
if (!path) { | ||
return; | ||
} | ||
|
||
const pathSegments: string[] = parsed.path.split(pathSegmentPattern); | ||
if (pathSegments.length > 1 && pathSegments[0].match(ignoredPattern)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wondering if following a similar logic as in JupyterLab (disposing the command after routing) could help keep things simpler and avoid special cases using patterns?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue No. #7216
Problem
The problem arises whenever these keywords, namely {“notebooks”, “edit”, ”consoles”, ”terminals”}, are detected in the path. This leads to undesired behaviour when directories with these keywords are present.
Some of our plugins actively monitor the URL path for the above keywords to execute corresponding commands. When these plugins come across the path with matching keywords(directories) during file browsing(tree view), they are forced to execute the associated command, which causes the issue.
Solution
Thank you for considering my contribution. And I welcome any feedback or suggestions for further improvements.