Notebook 6 CI updates #7344
Draft
Notebook 6 CI updates #7344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
RRosio
commented
Apr 26, 2024
RRosio
commented
- check-links
- python tests on macos
- python tests on windows
- selenium tests
krassowski
reviewed
Apr 26, 2024
| @@ -56,7 +56,7 @@ Launch with: | |||
|
|
|||
| ### Running in a remote installation | |||
|
|
|||
| You need some configuration before starting Jupyter notebook remotely. See [Running a notebook server](https://jupyter-notebook.readthedocs.io/en/stable/public_server.html). | |||
There was a problem hiding this comment.
Is it possible to point to older version of Jupyter notebook docs instead? The jupyter-server options will not work with the notebook server.
.github/workflows/check-release.yml
Outdated
| @@ -65,3 +65,5 @@ jobs: | |||
| - name: Check Links | |||
| if: ${{ matrix.group == 'link_check' }} | |||
| uses: jupyter-server/jupyter_releaser/.github/actions/check-links@v1 | |||
| with: | |||
| ignore-links: 'https://travis-ci.org/jupyter/notebook.svg?branch=master' | |||
There was a problem hiding this comment.
Imo that link sounds be just removed, wherever it is.
There was a problem hiding this comment.
Thank you for your feedback @krassowski! I have removed this link and updated the public server docs link to point to the 6.5.4 docs build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.