-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update async.vim #134
Open
k-takata
wants to merge
3
commits into
master
Choose a base branch
from
update-async-vim
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Update async.vim #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k-takata
force-pushed
the
update-async-vim
branch
from
April 21, 2021 14:35
d774495
to
365333e
Compare
It seems to hang up on Neovim. Why? |
0fb846e avoid has_key check for on_stdout 236debf Merge pull request #43 from prabirshrestha/fix-retry c4d6144 Set waittime 8fc5956 Increment l:retry f6b87c1 Trim null 69a4a5c Merge pull request #42 from mattn/fix-null 35b369f Trim null 36e97f0 Merge pull request #41 from mattn/tcp 2addfc3 Skip neovim 625cd40 Add test for async#job#connect fa1b82d Retry a4f4005 Add async#job#connect 6102020 Add :AsyncEmbed d15123a Add default value when reading 'close_stdin' from input options bb3aceb Make `opts` argument of `async#job#send`, optional 732cf48 Pass `close_stdin` as a Dictionary rather than bool argument ab499e8 Better / safer management of non-blocking channels a0f4e4e Wait for transmit buffer to be empty, before calling `ch_close_in` ada658f Add support for sending data and closing stdin at the same time 42371b5 fix not restoring cpoptions f67ecb5 Support 'cwd' option in jobstart 627a8c4 Do NOT remove job in job_stop but on_exit 8998efb Add tests for Neovim 91c3f2b Do NOT raise E900 on invalid jobid f301455 doc: Update Embedding section 8da445b default to noblock if supported by vim 8 to avoid deadlocks causing vim to hang (#31) 4bde72e Don't use workaround (#30) ff9177c add async#job#pid() (#28) 0521409 Fix variable name in example (#19) d721851 Merge pull request #25 from prabirshrestha/add-test 633414e Use partial argument 79d54f4 Merge pull request #27 from prabirshrestha/revert-22 c980166 Revert #22 d7c52bc Fix test d5e8819 Install vim 2a883ee Fix test 519430b Add tests 7627c81 Merge pull request #24 from prabirshrestha/fix-heavy ca41dab Buffer size must be more large 300493e Merge pull request #22 from mattn/fix-block 017c6a8 Fix .travis.yml 7b1dfec Fix .travis.yml d10fdb9 Start timer to read lazy 89bec95 Add "sleep 1m" to read blocked channel git-subtree-dir: autoload/minpac git-subtree-split: 0fb846e1eb3c2bf04d52a57f41088afb3395212e
These files are not needed in minpac.
It looks like the problem is due to mixing slashes and backslashes on Windows (see for example, neovim/neovim#13787). With the following patch everything looks all right: diff --git a/autoload/minpac.vim b/autoload/minpac.vim
index e28716c..d11f148 100644
--- a/autoload/minpac.vim
+++ b/autoload/minpac.vim
@@ -37,6 +37,9 @@ function! minpac#init(...) abort
if l:packdir ==# ''
" If 'dir' is not specified, the first directory of 'packpath' is used.
let l:packdir = split(&packpath, ',')[0]
+ if has('nvim') && exists('+shellslash') && &shellslash
+ let l:packdir = tr(l:packdir, '\', '/')
+ endif
endif
let l:opt.minpac_dir = l:packdir . '/pack/' . l:opt.package_name |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Import the latest version of async.vim.
This should fix #131.