[FIX # 2184] Add clip, clip-path check; Add parent visibility check #2186
Conversation
…Does not provide detection for fields covered by overlays for performance.
|
Are there any common known sites that are affected by this change and can be used for testing? |
|
This fix does not work for me. I tested this with the first URL in the issue (https://felix026x.github.io/overlay.html) and after filling (with this change or without) |
Thanks for your comments. As we describe in the first thread, we do not consider the |
| clipPath = clipPath.trim(); | ||
| const ret = false; | ||
| if (clipPath.startsWith("inset")) { | ||
| ret = kpxcFields.isClippedPathInset(clipPath); |
There was a problem hiding this comment.
TypeError: Assignment to constant variable.
| if (clipPath.startsWith("inset")) { | ||
| ret = kpxcFields.isClippedPathInset(clipPath); | ||
| } else if (clipPath.startsWith("circle")) { | ||
| ret = kpxcFields.isClippedPathCircle(clipPath); |
There was a problem hiding this comment.
TypeError: Assignment to constant variable.
| } | ||
|
|
||
| kpxcFields.isClipped = function(clip, position) { | ||
| if (clip !== "auto" && clip.trim() !== "" && (position === "absolute" || position === "fixed")) { |
There was a problem hiding this comment.
The regex below this is not very readable. Is there any way to make it more simple? Also, you should use single quotes in the code instead of double quotes.
To solve Issue #2184, we modify the original method for visibility check, and consider the hidden techniques using
clipandclip-path. We also fix thestyleissue, where the original code utilizes the style of the inline element while overlooking the nested CSS styles. However, for performance overhead, we do not implement the detection for hidden fields caused by overlays.