Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rounding error in RGB functionality #1164

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Murat-U-Saglam
Copy link

The values before passed to Bokeh were not rounded as integers and were treated as float due to a decimal point. I have added robust checking and enforcement of ints within that function.

Bokeh RGB accepts integers, this error causes issues with serialisation as discussed in Issue

@bryevdv
Copy link

bryevdv commented Aug 7, 2024

FYI please check this works, I am not sure calling rint will be sufficient as it still (AFAIK) generates floating point values, that just happen to be integer values. But these may render like 2., 10. etc. and I believe this will still trip up the regex based input validation. Though really I would recommend collecting the results in a tuple and actually calling int on all the components to be safest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants