Misc YANG fixes #112
Merged
Misc YANG fixes #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
troglobit
commented
Aug 21, 2023
troglobit
commented
- Fix lost deviation and timezone enumerations
- Merge internal YANG revisions inside release cycle
- Drop old versions of native YANG models
- Lock down and restrict user shells
- Limit if:type to supported native types only
Signed-off-by: Joachim Wiberg <[email protected]>
Signed-off-by: Joachim Wiberg <[email protected]>
Signed-off-by: Joachim Wiberg <[email protected]>
|
Rebased against |
wkz
requested changes
Aug 22, 2023
This patch restricts the possible user shells to a subset of the list in /etc/shells, which is generated by Buildroot. The default is 'false' to prevent accidental shell access for non-admin role users. The default shell for the admin user is now /bin/clish, which can be further locked down before Infix v24.02 LTS. In case of internal error the default fallback shell is now set to the customizable LOGIN_SHELL, which currently is /bin/bash. Signed-off-by: Joachim Wiberg <[email protected]>
This further locks down confd to fall back to /bin/false as login shell in case of internal errors. Signed-off-by: Joachim Wiberg <[email protected]>
Signed-off-by: Joachim Wiberg <[email protected]>
Signed-off-by: Joachim Wiberg <[email protected]>
This patch adds a new infix-interface-type, derived from the IANA base type, allowing us to limit the list of supported native interface types. Basing on IANA interface type ensure compatibility with other models, e.g., standard/ieee/published/802.3/ieee802-ethernet-interface.yang, which attaches itself to all interfaces of type ianaift:ethernetCsmacd. Tested with yanglint and in Infix using ieee802-ethernet-interface.yang, the 'ethernet' container was properly attached to interfaces of type infixift:ethernet. Tab completion in the CLI now lists only the supported types. Signed-off-by: Joachim Wiberg <[email protected]>
The commit adds a missing description and reorders some yang statements to meet canonical ordering according to RFC7950, section 14. It also relocates the /interfaces/interfaces/infix-if:port augment to its own base model that the bridge (and later lag) models reference. Solving the bisarre ordering issues we've seen previously. Signed-off-by: Joachim Wiberg <[email protected]>
Signed-off-by: Joachim Wiberg <[email protected]>
|
Dropped the first commit, introducing the must expression, then adjusted the last if:type limiting commit, dropping the extension to the same must expression. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.