Support for save/restore system clock from file #796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
@wkz pretesting Finit patches, I'll make sure to add a ChangeLog update and a better PR description tomorrow. |
The RTC in the CN913x series does not have any "valid" bit, and this board (all revs) does not have any backup power connected, so it will return garbage values after every vold boot. It was therefore decided to disable the RTC completely and set system time manually, or using an NTP client. This way any time skips would only ever be forward, never backwards. Signed-off-by: Joachim Wiberg <[email protected]>
Signed-off-by: Joachim Wiberg <[email protected]>
Signed-off-by: Joachim Wiberg <[email protected]>
This fixes an annoying problem with `make run` when set to boot with a qcow2 disk image. By default the disk image was recreated every time the qemu.sh script was called. Also, add image check to enforce regen if broken. Signed-off-by: Joachim Wiberg <[email protected]>
Creating/Recreating the qcow2 image now logs to stdout, as does the check using qemu-img, which looks funny in raw mode. So let's delay the start of raw mode until just before starting qemu. Signed-off-by: Joachim Wiberg <[email protected]>
Signed-off-by: Joachim Wiberg <[email protected]>
Signed-off-by: Joachim Wiberg <[email protected]>
The string variable handling in configuring Finit did not follow the
Buildroot best practises. This patch adds stripping quotes from all
string variables before adding them as configure arguments.
This fixes issue with, e.g., this sneaky bastard:
configure --with-rtc-date=""2024-10-12 12:34:56""
Signed-off-by: Joachim Wiberg <[email protected]>
troglobit
force-pushed
the
rtc
branch
2 times, most recently
from
e50fa66
to
05cb932
Compare
Backport support for saving and restoring system time from a file on systems with broken RTC that reset to the future. With this support a system can be sure time only ever moves forward. Fix #794 Signed-off-by: Joachim Wiberg <[email protected]>
Signed-off-by: Joachim Wiberg <[email protected]>
Signed-off-by: Joachim Wiberg <[email protected]>
|
@mattiaswal maybe you can focus your review on the non RTC-related changes? (If you're pressed for time, that is.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR mainly addresses issues with malfunctioning RTC devices. A few minor "infra" changes have also been included, listed at the end:
Major:
Minor:
mntscript, add missing-nto testqemu.sh -cwhen disk image is selectedqemu.shis startedqemu.shqemu.shChecklist
Tick relevant boxes, this PR is-a or has-a: