Properly handle boolean values set to false

kirschbaum-development · Feb 19, 2024 · b351129 · b351129
1 parent c82edec
commit b351129
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/src/Checks/PreflightCheck.php b/src/Checks/PreflightCheck.php
@@ -123,7 +123,7 @@ protected function checkConfig(Result $result): Result
         $missingKeys = [];
 
         foreach ($this->requiredConfig as $configKey) {
-            if (! config()->has($configKey) || empty(config($configKey))) {
+            if (! config()->has($configKey) || ! is_bool(config($configKey)) && empty(config($configKey))) {
                 $missingKeys[] = $configKey;
             }
         }

diff --git a/tests/Checks/ConfigurationTest.php b/tests/Checks/ConfigurationTest.php
@@ -27,6 +27,19 @@ public function testPassesWhenConfigIsSet()
         $this->assertPassed($result);
     }
 
+    /**
+     * @test
+     */
+    public function testPassesWhenConfigIsBooleanAndSetToFalse()
+    {
+        $config = ['test1' => false];
+        config($config);
+        $preflightCheck = new Configuration(array_keys($config));
+
+        $result = $preflightCheck->check(new Result('Test\Test'));
+        $this->assertPassed($result);
+    }
+
     /**
      * @test
      */