Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A compilation fix, and minor issue with a NULL reference #1

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

JamesCC
Copy link

@JamesCC JamesCC commented Sep 8, 2017

Thanks for providing this code, it worked very well for us.

We are compiling on an iMX6 using gcc (from a freescale community YOCTO build) and found a couple of compile warnings - easily fixable.

More importantly the jbc file we where using - it did not have any descriptions in it, and as the description pointer was not reset to NULL, this resulted in a junk being displayed on the screen.

@mwalle
Copy link
Collaborator

mwalle commented Sep 8, 2017

Hi,
thanks for the fixes. They look good. Please add a Signed-off-by to every commit and i'll pull this request.

@ilkkak
Copy link

ilkkak commented Oct 10, 2017

Hi, thanks for the bytecode player. There were some additional initialization problems when listing the actions with my .jbc, but it's now working and I'm successfully programming on arm64 platform. Works at least on x86-64 too. I don't seem to have write access(??? new to github) but I forked this and made a version using the FT232H (which is what I happened to have) using MPSSE mode instead of GPIO. It's easy to combine the two if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants