Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Scope down IAM policy #2229

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[WIP] Scope down IAM policy #2229

wants to merge 1 commit into from
+162 −50

Conversation

ConnorJC3
Copy link
Contributor

@ConnorJC3 ConnorJC3 commented Nov 14, 2024 •
edited
Loading

What type of PR is this?

/kind cleanup
/kind documentation

What is this PR about? / Why do we need it?

Updates the example IAM policy with the following changes:

  • Reverts from * partition to aws partition for consistency with the managed policy (TODO: Add documentation about this - will be done in a future revision of the PR)
  • Moves mutating actions from * resource to more specific resources
  • Consolidates some statements that can be combined with ForAnyValue
  • Restricts modification of tags to only allow adding managed tags during volume/snapshot creation

How was this change tested?

Manually + CI

Does this PR introduce a user-facing change?

TODO - WIP

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 14, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from connorjc3. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 14, 2024
@github-actions GitHub Actions
Copy link

Code Coverage Diff

This PR does not change the code coverage

@torredil
Copy link
Member

/retest

@ConnorJC3 ConnorJC3 force-pushed the update-iam-policy branch 2 times, most recently from 9f612ec to 8cc88cf Compare November 15, 2024 16:17
@ConnorJC3
[WIP] Update IAM policy
69d15b7 
Signed-off-by: Connor Catlett <[email protected]>
@torredil
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ElijahQuinones ElijahQuinones Awaiting requested review from ElijahQuinones

@torredil torredil Awaiting requested review from torredil

Assignees

@torredil torredil

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ConnorJC3 @k8s-ci-robot @torredil