Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Use namespace of the reference on external.Get #11361

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

🐛 Use namespace of the reference on external.Get #11361

wants to merge 6 commits into from

Conversation

Danil-Grigorev
Copy link
Member

@Danil-Grigorev Danil-Grigorev commented Oct 31, 2024 •
edited
Loading

What this PR does / why we need it:

Using external.Get method may be problematic when the resources referenced are located in a different namespace from the originating resource, leading to not found errors on the lookup attempts.

Template definitions provide all information, including namespace of the object in the references, so using those instead.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Related to #5673

/area clusterclass
/area api

@k8s-ci-robot k8s-ci-robot added area/clusterclass Issues or PRs related to clusterclass cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 31, 2024
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 31, 2024
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 1, 2024
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 1, 2024
@Danil-Grigorev Danil-Grigorev force-pushed the standardize-references branch 3 times, most recently from 7672253 to edbd553 Compare November 1, 2024 12:02
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 1, 2024
@Danil-Grigorev Danil-Grigorev force-pushed the standardize-references branch 5 times, most recently from 511364f to b03866f Compare November 1, 2024 13:58
@Danil-Grigorev
Copy link
Member Author

/test pull-cluster-api-e2e-mink8s-main

@Danil-Grigorev Danil-Grigorev mentioned this pull request Nov 4, 2024
Merged
@sbueringer
Copy link
Member

/test pull-cluster-api-e2e-mink8s-main

@sbueringer sbueringer added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Nov 4, 2024
sbueringer
sbueringer reviewed Nov 4, 2024
View reviewed changes
Copy link
Member

@sbueringer sbueringer left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx, one nit

(if e2e tests work)

controllers/external/util.go Outdated Show resolved Hide resolved
@sbueringer
Copy link
Member

/test pull-cluster-api-e2e-main

@Danil-Grigorev
Copy link
Member Author

/test pull-cluster-api-e2e-main

@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from enxebre. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@alexander-demicev alexander-demicev mentioned this pull request Nov 5, 2024
Open
@sbueringer
Copy link
Member

/hold

just for a bit until #11364 is merged. Just want to avoid rebases on 11364 (shouldn't take too long)

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 5, 2024
@Danil-Grigorev
Copy link
Member Author

/test pull-cluster-api-e2e-main

@Danil-Grigorev
Copy link
Member Author

/test pull-cluster-api-e2e-main
/test pull-cluster-api-e2e-mink8s-main

@Danil-Grigorev
Copy link
Member Author

It seems e2e are now passing @sbueringer, WDYT?

@Danil-Grigorev Danil-Grigorev mentioned this pull request Nov 11, 2024
Open
@sbueringer
Copy link
Member

We might need a rebase after #11393 merged

@sbueringer
Copy link
Member

/hold cancel

I'll take another look soon

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 11, 2024
@Danil-Grigorev
Copy link
Member Author

I addressed additional e2e test coverage in #11395 based on combined changes and this PR. Hope it helps in review.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 13, 2024
@sbueringer
Copy link
Member

Pretty far up in my review TODO list now. @Danil-Grigorev Can you please rebase?

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 13, 2024
@k8s-ci-robot
Copy link
Contributor

@Danil-Grigorev: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-apidiff-main 6969124 link false /test pull-cluster-api-apidiff-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@sbueringer
Copy link
Member

/test pull-cluster-api-e2e-main

furkatgofurov7
furkatgofurov7 reviewed Nov 15, 2024
View reviewed changes
Copy link
Member

@furkatgofurov7 furkatgofurov7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@furkatgofurov7 furkatgofurov7 furkatgofurov7 left review comments

@sbueringer sbueringer sbueringer left review comments

@chrischdi chrischdi Awaiting requested review from chrischdi

@richardcase richardcase Awaiting requested review from richardcase

@enxebre enxebre Awaiting requested review from enxebre

Assignees

@enxebre enxebre

Labels
area/clusterclass Issues or PRs related to clusterclass cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Danil-Grigorev @sbueringer @enxebre @k8s-ci-robot @furkatgofurov7