Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove our custom defaulter when controller-runtime fix is released #3469

Open
mimowo opened this issue Nov 6, 2024 · 1 comment
Open

Remove our custom defaulter when controller-runtime fix is released #3469

mimowo opened this issue Nov 6, 2024 · 1 comment
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.

Comments

@mimowo
Copy link
Contributor

mimowo commented Nov 6, 2024

What would you like to be cleaned:

We have a custom defaulter in Kueue registered via pkg/controller/jobframework/webhook/builder.go to workaround a bug in controller-runtime which was dropping unknown fields in webhooks.

For that we need to await until the fix kubernetes-sigs/controller-runtime#2982 is released in controller-runtime, probably 0.20.

Why is this needed:

To cleanup Kueue code, and use a fix which allows to also remove fields in Kueue's webhooks (if we need it).

@mimowo mimowo added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Nov 6, 2024
@mimowo
Copy link
Contributor Author

mimowo commented Nov 6, 2024

cc @tenzen-y @mbobrovskyi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
None yet
Development

No branches or pull requests

1 participant