-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
7435 Support New Alibaba Cloud ENV Variables names for RRSA Authoriza… #7436
base: master
Are you sure you want to change the base?
7435 Support New Alibaba Cloud ENV Variables names for RRSA Authoriza… #7436
Conversation
…tion in Cluster Autoscaler Signed-off-by: Maxim Rubchinsky <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: maximrub The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @maximrub. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
cc @ringtail |
cc @IrisIris Pls take a look. |
Hi @ringtail, can someone have a look? |
@maximrub LGTM. It would be even better if you could add a unit test for this new function 'FirstNotEmpty'. |
Signed-off-by: Maxim Rubchinsky <[email protected]>
@Shubham82 can you help with this pr also? thank you |
LGTM |
/lgtm |
cc @x13n Thanks! |
Signed-off-by: Maxim Rubchinsky <[email protected]>
New changes are detected. LGTM label has been removed. |
Thanks! Can you also squash the commits? |
Which component this PR applies to?
cluster-autoscaler
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR adds support for the newly declared official environment variable names by Alibaba Cloud for RRSA to authorize pods to access different cloud services. This change enables compatibility with both the existing and new ENV variable names, ensuring seamless authorization for pods accessing various Alibaba Cloud services.
This update is essential for users transitioning to the updated naming conventions while maintaining support for legacy configurations.
Which issue(s) this PR fixes:
Fixes #7435
Special notes for your reviewer:
Does this PR introduce a user-facing change?
no