-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding the App Bar section #6036
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: NishantSinghhhhh <[email protected]>
…veness Signed-off-by: NishantSinghhhhh <[email protected]>
🚀 Preview for commit 86f1a0f at: https://671e720d8a0d5368cb7ce4be--layer5.netlify.app |
@NishantSinghhhhh Please add it as an agenda item to the meeting minutes. |
Sir today I will be travelling back to my hometown, so I am really sorry, but I won't be able to attend the meet , is there any other way around? |
@sudhanshutech @vishalvivekm z can you review the PR |
@NishantSinghhhhh merge conflicts |
Signed-off-by: NISHANT SINGH <[email protected]>
Signed-off-by: NishantSinghhhhh <[email protected]>
🚀 Preview for commit 02a8ce3 at: https://672224ec00d5ef9335e8329e--layer5.netlify.app |
Signed-off-by: NishantSinghhhhh <[email protected]>
🚀 Preview for commit 4c32044 at: https://67223878fce926067d7afd72--layer5.netlify.app |
Signed-off-by: NishantSinghhhhh <[email protected]>
🚀 Preview for commit 0960ec0 at: https://67223e744861b90c310ffd50--layer5.netlify.app |
Signed-off-by: NishantSinghhhhh <[email protected]>
Signed-off-by: NISHANT SINGH <[email protected]>
🚀 Preview for commit 36db130 at: https://672f4b1f7fd1e31e6446bb32--layer5.netlify.app |
@sudhanshutech sir can you review the changes that I have done |
Description:
This PR introduces detailed documentation for the App Bar component, outlining its purpose, usage, and customizable options. The documentation provides insights into different App Bar variations, including configurations for Basic App Bar, App Bar with Menu, and App Bar with integrated Search functionality. Developers can now gain a comprehensive understanding of how to implement the App Bar effectively, tailor it to specific use cases, and maintain visual and functional consistency across the application.
Changes Include:
1-Overview of App Bar component’s purpose and primary function in guiding navigation and user interactions.
2-Descriptions of various App Bar types and scenarios best suited for each, such as Basic App Bar, App Bar with Menu, and App Bar with Search.
3-Detailed guidelines for content structure, icon/button usage, and design considerations to ensure a cohesive user experience.
4-Example implementations for each App Bar variation to demonstrate practical usage and customizations.
5-Accessibility best practices and recommendations for color, contrast, and iconography to align with UI standards.
Changes other then This:
1- I have added 1 component in Reusecore , the component is code-block.js , It will be used in each and every component , thus creating new code-block.js for every component is not a good idea , thus came up with a component
Notes for Reviewers:
Please review the examples and descriptive content for clarity and completeness. Feedback on additional use cases or any modifications to styling or accessibility guidelines would be greatly appreciated.
Issue Number : ##5902
Signed commits