Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[test fix] test_mini_models_with_logits and test_mini_models are backwards #380

Closed
wants to merge 2 commits into from
Closed

[test fix] test_mini_models_with_logits and test_mini_models are backwards #380

wants to merge 2 commits into from

Conversation

tyler-romero
Copy link
Collaborator

Summary

Somehow the purposes of these two files got flipped. Caused me some confusion while debugging a separate issue.

Testing Done

  • Hardware Type: 4090
  • [ x ] run make test to ensure correctness
  • [ x ] run make checkstyle to ensure code style
  • [ x ] run make test-convergence to ensure convergence

@tyler-romero tyler-romero marked this pull request as ready for review November 14, 2024 07:10
@tyler-romero
Copy link
Collaborator Author

tyler-romero commented Nov 14, 2024 •
edited
Loading

...

@tyler-romero tyler-romero deleted the tyler/fix-logit-tests branch November 14, 2024 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tyler-romero