[#573] BackupRequest doesn't work with streaming #574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nizarm
reviewed
Mar 31, 2021
d2/src/main/java/com/linkedin/d2/balancer/clients/BackupRequestsClient.java
Show resolved
Hide resolved
nizarm
reviewed
Mar 31, 2021
added 2 commits
March 31, 2021 11:10
|
@nizarm I figured we need to use the same copy of RequestContext when sending request so that the targetHostHint can work. |
This reverts commit e36a64d.
nizarm
requested changes
Apr 1, 2021
d2/src/main/java/com/linkedin/d2/balancer/clients/BackupRequestsClient.java
Outdated
Show resolved
Hide resolved
nizarm
approved these changes
Apr 1, 2021
|
Nice work, thanks for taking care of this usecase |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details can be found in #573.
The fix is to buffer the body and resend if needed.
cc @nizarm @ssheng