Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial running version on Windows #9

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Initial running version on Windows #9

wants to merge 7 commits into from

Conversation

66Leo66
Copy link

@66Leo66 66Leo66 commented Aug 15, 2023

Related: #5

Added compiler macros to isolate platform-specific code, allowing it to compile on Windows.

Working:

  • Basic function
  • Open commit window shortcut

Not working:

  • Window vibrancy (had no luck with mica/acrylic/blur - they just don't work)
  • Tiny black space on rounded corner
  • Open settings shortcut (no idea, maybe some broken cache on my system)

image

image

image

66Leo66 and others added 6 commits August 15, 2023 16:26
@66Leo66
Initial running version on Windows
740185b 
- Ugly `cfg` used to disable MacOS-specific code.
- `apply_mica` vibrancy looks so bad.
- Shortcut's broken. Will investigate soon.

This commit is made using commit!!
@66Leo66
Shortcut fix
09a7bfc 
- Now default shortcut for Windows is usable.
- blur effect is broken as well.
- Settings shortcut looks broken.
@m1guelpf
Run Windows on CI
2f524c3
@m1guelpf
Actually upload Windows build results to CI
e6b232b
@m1guelpf
whoops, wrong name
05e7a21
@m1guelpf
Use CommandOrControl for keyboard shortcuts
ecdc798
@m1guelpf
Copy link
Owner

m1guelpf commented Aug 16, 2023 •
edited
Loading

@66Leo66 Amazing work! I've added a build target for Windows on CI, so that anyone else following this (and me once I get back to my PC) can try this out.

I've also switched to using CommandOrControl for the keyboard shortcut, which should hopefully simplify the changes needed to the frontend (tho the module that displays the shortcut still needs some changes, namely displaying Ctrl instead of ⌘, and maybe the Windows key?).

I'm ok with disabling window vibrancy if you can't get it working (we'll have to do this in Linux too I think).

@m1guelpf m1guelpf linked an issue Aug 16, 2023 that may be closed by this pull request
Windows build #5
Open
@66Leo66
Copy link
Author

66Leo66 commented Aug 16, 2023

Correct shortcut hint is being displayed in the tray menu now.

Settings shortcut only works when focusing commit's main window. Is this the intended behaviour?

@66Leo66
Copy link
Author

66Leo66 commented Aug 16, 2023 •
edited by unfurl-links bot
Loading

Regarding window vibrancy:
I have found the problem. Making frontend use background: transparetn is required to see the effects.
However, since we are using https://github.com/tauri-apps/window-vibrancy, here's the situation:

  • Not on Linux: https://github.com/tauri-apps/window-vibrancy#platform-specific

  • blur is super laggy, don't use

  • arcylic feels okay on Win11 22H2 build 22621. Haven't tested on Win10 1903+ which is said to have bad performance. It reflect the color under the window.
    image

  • mica won't encounter performance issue, but it's Win11 only and it reflect the color of the wallpaper, so looks bad in some occurences.
    image
    image

GitHub
Make your windows vibrant. Contribute to tauri-apps/window-vibrancy development by creating an account on GitHub.
GitHub
Make your windows vibrant. Contribute to tauri-apps/window-vibrancy development by creating an account on GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Windows build
2 participants
@66Leo66 @m1guelpf