Remove some Gc holes #1296
Open
Remove some Gc holes #1296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neon-sunset
reviewed
Oct 30, 2024
| Unsafe.CopyBlock( | ||
| ref targetPtr, | ||
| ref sourcePtr, | ||
| (uint)sourceLengthInBytes); |
There was a problem hiding this comment.
Cast to uint here will truncate the chunk of memory being copied to 4GiB. Instead, this could be done with pinning both byrefs and calling Buffer.MemoryCopy which does the right thing. Happy to see more people discovering an amazing project that ILGPU is.
|
Related: #1209 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Going via Unsafe.AsPointer risks creating Gc holes where the GC has moved the memory but the pointer has not been updates
Use safer alternatives via
ref