Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow overriding cmake target names, install pdb symbols on msvc compiler #976

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Allow overriding cmake target names, install pdb symbols on msvc compiler #976

wants to merge 3 commits into from

Commits on May 30, 2024

  1. Ignore build directory.

    @stevewgr
    stevewgr committed May 30, 2024
    Configuration menu
    Copy the full SHA
    8e47fc4 View commit details
    Browse the repository at this point in the history

  2. Allow overriding cmake target names. 

    Note that this is useful in particular when you want to use consistent
library names across all platforms, because on windows both shared and
static libs use the same *.lib extension in comparison to unix systems
where *.so is shared and *.a is static or on macos dylib for dynamic
libraries.
Surely we can also configure target properties and set OUTPUT_NAME, but
that creates other questions about configurations that do not match with
the target name. This is considered a bad practice and hence the
approach of overriding the target names should also influence the output
names and other configurations that may depend upon it.
    @stevewgr
    stevewgr committed May 30, 2024
    Configuration menu
    Copy the full SHA
    7d143e2 View commit details
    Browse the repository at this point in the history

  3. Ensure we install *.pdb files for symbols on msvc as well.

    @stevewgr
    stevewgr committed May 30, 2024
    Configuration menu
    Copy the full SHA
    1745729 View commit details
    Browse the repository at this point in the history