Detect when virtualTypes move elsewhere #72
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While working on magento/magento2#32690, it was noticed that a
virtualType
which is used in multiple modules (namelyshellBackground
used in bothMagento_Cron
andMagento_MessageQueue
). Moving this toapp/etc/di.xml
where it belongs triggered an automated test failure from this tool. This pull request aims to handle this case as expected.Manual testing scenarios
Unit tests are included with this change. Without the code change, these unit tests fail.
Contribution checklist