Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect when virtualTypes move elsewhere #72

Merged
merged 2 commits into from
Mar 7, 2024

Conversation

fredden
Copy link
Member

@fredden fredden commented May 25, 2023

Description

While working on magento/magento2#32690, it was noticed that a virtualType which is used in multiple modules (namely shellBackground used in both Magento_Cron and Magento_MessageQueue). Moving this to app/etc/di.xml where it belongs triggered an automated test failure from this tool. This pull request aims to handle this case as expected.

Manual testing scenarios

Unit tests are included with this change. Without the code change, these unit tests fail.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@ihor-sviziev
Copy link
Contributor

@sidolov please merge this pull request

@engcom-Charlie
Copy link

@sidolov can you please merge this PR. magento/magento2#32690 is depended on this PR.

@sidolov
Copy link
Contributor

sidolov commented Mar 7, 2024

@magento import pr to magento-commerce/magento-semver repository

@m2-github-services
Copy link

@sidolov the Pull Request is successfully imported.

@magento-devops-reposync-svc magento-devops-reposync-svc merged commit de42815 into magento:develop Mar 7, 2024
7 checks passed
@fredden fredden deleted the app-etc-di.xml branch March 7, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants