Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No update must be a boolean, int given for bin/magent sampledata:deploy|remove --no-update #39345

Open
wants to merge 1 commit into
base: 2.4-develop
Choose a base branch
from

Conversation

JeroenBoersma
Copy link
Member

@JeroenBoersma JeroenBoersma commented Nov 7, 2024

Description (*)

When adding or removing sample data you can tell the composer update command to not invoke the update command right away. Since newer versions type checking is set for this argument and it must be of type boolean instead of a integer.

Fixed Issues (if relevant)

  1. Fixes bin/magento sampledata:deploy --no-update throws an exception #39344

Manual testing scenarios (*)

  1. Install a clean Magento 2 installation
  2. Try to deploy sample data without directly updating --no-update
  3. A error was thrown, not anymore

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

fixes magento#39344

When adding or removing sample data you can tell the composer update
command to not invoke the update command right away. Since newer
versions type checking is set for this argument and it must be of type
boolean instead of a integer.
Copy link

m2-assistant bot commented Nov 7, 2024

Hi @JeroenBoersma. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.


For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@JeroenBoersma
Copy link
Member Author

@magento run all tests

@m2-community-project m2-community-project bot added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. labels Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: pending review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bin/magento sampledata:deploy --no-update throws an exception
1 participant