You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A version label is required. A maintainer must add one.
🚫
No linked issue found. Please link a relevant open issue by adding the text "closes #<issue_number>" or "closes JIRA-<issue_number>" in your PR.
🚫
Missing "Verification Steps" section. Please add it back, with detail.
🚫
Missing "Description" section. Please add it back, with detail.
Messages
📖
DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed).
📖
Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.
If your PR is missing information, check against the original template here. At a minimum you must have the section headers from the template and provide some information in each section.
Cypress tests in the following files did not pass 😔. All tests must pass before this PR can be merged
Verify content:
Error: Image size (1280x1869) different than saved snapshot size (1280x1463).
See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/aboutUsPage/aboutUsPage.spec.js/__diff_output__/AboutUs.diff.png
Verify content:
Error: Image size (1280x2069) different than saved snapshot size (1280x1846).
See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/customerService/customerService.spec.js/__diff_output__/Customer-Service-Page.diff.png
verify buttons content:
Error: Image size (1280x8562) different than saved snapshot size (1280x7846).
See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/buttons.spec.js/__diff_output__/Page-Builder-Buttons-Page.diff.png
verify column content:
Error: Image size (1280x7689) different than saved snapshot size (1280x6686).
See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/column.spec.js/__diff_output__/Page-Builder-Column-Page.diff.png
,should apply mediaQuery styles:
Error: Image size (1280x1564) different than saved snapshot size (1280x1404).
See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/column.spec.js/__diff_output__/Column-media-query-(Desktop).diff.png
verify divider content:
Error: Image size (1280x3791) different than saved snapshot size (1280x2994).
See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/divider.spec.js/__diff_output__/Page-Builder-Divider-Page.diff.png
verify dynamic block content:
Error: Image size (1280x1564) different than saved snapshot size (1280x1404).
See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/dynamicBlock.spec.js/__diff_output__/Page-Builder-Dynamic-Block-Snapshot.diff.png
verify google map api load with content:
Error: Image size (1280x11380) different than saved snapshot size (1280x10130).
See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/map.spec.js/__diff_output__/Page-Builder-Verify-Map---All-content.diff.png
verify mocked google map api with two markers and click event:
Error: Image size (1280x1580) different than saved snapshot size (1280x1404).
See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/map.spec.js/__diff_output__/Page-Builder-Verify-Map---2-Locations.diff.png
verify slider content:
Error: Image size (1280x1564) different than saved snapshot size (1280x1404).
See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/slider.spec.js/__diff_output__/Page-Builder-Slider-Page.diff.png
verify slider content 2:
Error: Image size (1280x1564) different than saved snapshot size (1280x1404).
See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/slider.spec.js/__diff_output__/Page-Builder-Slider-Page-2.diff.png
verify slider content 3:
Error: Image size (1280x1564) different than saved snapshot size (1280x1404).
See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/slider.spec.js/__diff_output__/Page-Builder-Slider-Page-3.diff.png
verify slider content 4:
Error: Image size (1280x1564) different than saved snapshot size (1280x1404).
See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/slider.spec.js/__diff_output__/Page-Builder-Slider-Page-4.diff.png
verify slider content 5:
Error: Image size (1280x1564) different than saved snapshot size (1280x1404).
See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/slider.spec.js/__diff_output__/Page-Builder-Slider-Page-5.diff.png
verify slider content 6:
Error: Image size (1280x1564) different than saved snapshot size (1280x1404).
See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/slider.spec.js/__diff_output__/Page-Builder-Slider-Page-6.diff.png
verify slider content 7:
Error: Image size (1280x5265) different than saved snapshot size (1280x4828).
See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/slider.spec.js/__diff_output__/Page-Builder-Slider-Page-7.diff.png
verify slider content 8:
Error: Image size (1280x2755) different than saved snapshot size (1280x2678).
See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/slider.spec.js/__diff_output__/Page-Builder-Slider-Page-8.diff.png
verify slider content 9:
Error: Image size (1280x5359) different than saved snapshot size (1280x5282).
See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/slider.spec.js/__diff_output__/Page-Builder-Slider-Page-9.diff.png
verify slider content 10:
Error: Image size (1280x2749) different than saved snapshot size (1280x2380).
See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/slider.spec.js/__diff_output__/Page-Builder-Slider-Page-10.diff.png
verify slider content 11:
Error: Image size (1280x6179) different than saved snapshot size (1280x5510).
See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/slider.spec.js/__diff_output__/Page-Builder-Slider-Page-11.diff.png
verify slider content 12:
Error: Image size (1280x5234) different than saved snapshot size (1280x4398).
See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/slider.spec.js/__diff_output__/Page-Builder-Slider-Page-12.diff.png
,should apply mediaQuery styles:
Error: Image size (1280x1614) different than saved snapshot size (1280x1454).
See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/slider.spec.js/__diff_output__/Slider-media-query-(Desktop).diff.png
verify banner content:
Error: Image size (1280x2004) different than saved snapshot size (1280x1882).
See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/banner.spec.js/__diff_output__/Page-Builder-Home-Page.diff.png
verify banner content2:
Error: Image size (1280x3994) different than saved snapshot size (1280x3872).
See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/banner.spec.js/__diff_output__/Page-Builder-Home-Page2.diff.png
verify banner content3:
Error: Image size (1280x3994) different than saved snapshot size (1280x3872).
See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/banner.spec.js/__diff_output__/Page-Builder-Home-Page3.diff.png
verify banner content4:
Error: Image size (1280x3434) different than saved snapshot size (1280x3312).
See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/banner.spec.js/__diff_output__/Page-Builder-Home-Page4.diff.png
verify banner content5:
Error: Image size (1280x5054) different than saved snapshot size (1280x4932).
See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/banner.spec.js/__diff_output__/Page-Builder-Home-Page5.diff.png
verify banner content6:
Error: Image size (1280x5939) different than saved snapshot size (1280x5580).
See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/banner.spec.js/__diff_output__/Page-Builder-Home-Page6.diff.png
verify banner content7:
Error: Image size (1280x3826) different than saved snapshot size (1280x3320).
See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/banner.spec.js/__diff_output__/Page-Builder-Home-Page7.diff.png
verify banner content8:
Error: Image size (1280x3115) different than saved snapshot size (1280x2801).
See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/banner.spec.js/__diff_output__/Page-Builder-Home-Page8.diff.png
verify banner content9:
Error: Image size (1280x3568) different than saved snapshot size (1280x3401).
See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/banner.spec.js/__diff_output__/Page-Builder-Home-Page9.diff.png
verify banner content10:
Error: Image size (1280x8574) different than saved snapshot size (1280x6700).
See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/banner.spec.js/__diff_output__/Page-Builder-Home-Page10.diff.png
,should apply mediaQuery styles:
Error: Image size (1280x2656) different than saved snapshot size (1280x2624).
See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/banner.spec.js/__diff_output__/Banner-media-query-(Desktop).diff.png
verify smoke test content:
Error: Image size (1280x7437) different than saved snapshot size (1280x7661).
See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/smokeTest.spec.js/__diff_output__/Page-Builder-Smoke-Test.diff.png
Cypress tests in the following files did not pass 😔. All tests must pass before this PR can be merged
user should be able to access the Categories via Home page and from Main Menu left drawer:
AssertionError: Timed out retrying after 30000ms: expected '[ , 2 more... ]' to be 'visible'
This element [ <a.categoryLeaf-target-IF0.flex.flex-auto.justify-start.h-[3.5rem].items-center.-mx-5.px-sm.w-full>, 2 more... ] is not visible because its parent <aside.navigation-root_open-qjl.navigation-root-eCb.bg-white.bottom-0.grid.left-0.max-w-modal.opacity-0.overflow-hidden.fixed.top-0.w-full.z-menu.invisible.shadow-modal> has CSS property: visibility: hidden
user should be able to add and update gift options:
CypressError: Timed out retrying after 30000ms: cy.clear() failed because this element:
CypressError: Timed out retrying after 60000ms: cy.wait() timed out waiting 60000ms for the 1st request to the route: gqlGetStoreConfigDataQuery. No request ever occurred.
User shouldn't be able to add a CustomizableProduct from category page:
AssertionError: Timed out retrying after 30000ms: Expected to find element: [data-cy="Header-root"] [data-cy="CartTrigger-counter"], but never found it.
user can edit account information with default badge position:
CypressError: Timed out retrying after 30050ms: cy.click() failed because this element is not visible:
This element <button.linkButton-root-Bk1.clickable-root-3it.cursor-pointer.inline-flex.items-center.justify-center.leading-none.pointer-events-auto.text-center.font-semibold.max-w-full.text-brand-dark.underline.hover_text-colorDefault> is not visible because its parent <div.editForm-changePasswordButtonContainer-J0y.pt-xs> has CSS property: visibility: hidden
Fix this problem, or use {force: true} to disable error checking.
This element <button.linkButton-root-Bk1.clickable-root-3it.cursor-pointer.inline-flex.items-center.justify-center.leading-none.pointer-events-auto.text-center.font-semibold.max-w-full.text-brand-dark.underline.hover_text-colorDefault> is not visible because its parent <div.editForm-changePasswordButtonContainer-J0y.pt-xs> has CSS property: visibility: hidden
Fix this problem, or use {force: true} to disable error checking.
CypressError: Timed out retrying after 60000ms: cy.wait() timed out waiting 60000ms for the 1st request to the route: gqlSignInAfterCreateMutation. No request ever occurred.
user should be able to add and remove products from wishlist:
CypressError: Timed out retrying after 60000ms: cy.wait() timed out waiting 60000ms for the 1st request to the route: gqlSignInAfterCreateMutation. No request ever occurred.
user should be able to create a new account and edit their information:
CypressError: Timed out retrying after 60000ms: cy.wait() timed out waiting 60000ms for the 1st request to the route: gqlSignInAfterCreateMutation. No request ever occurred.
The response we received from your web server was:
502: Bad Gateway
This was considered a failure because the status code was not 2xx.
If you do not want status codes to cause failures pass the option: failOnStatusCode: false
should display Default Store View and USD currency by default:
AssertionError: Timed out retrying after 30000ms: Expected to find element: [data-cy="Header-switchers"] [data-cy="StoreSwitcher-root"] [data-cy="StoreSwitcher-trigger"], but never found it.
should display EUR currency by default if French Store View is selected:
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #4319