Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rendering flowchart open links with arrows #6043

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

mnito
Copy link

@mnito mnito commented Nov 9, 2024

📑 Summary

Fixes issue where open links in flowcharts are rendered with arrows

Resolves #5813

📋 Tasks

Make sure you

  • 📖 have read the contribution guidelines
  • 💻 have added necessary unit/e2e tests.
  • 📓 have added documentation. Make sure MERMAID_RELEASE_VERSION is used for all new features.
  • 🦋 If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Copy link

changeset-bot bot commented Nov 9, 2024

🦋 Changeset detected

Latest commit: 10f9a9b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
mermaid Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the Type: Bug / Error Something isn't working or is incorrect label Nov 9, 2024
Copy link

netlify bot commented Nov 9, 2024

Deploy Preview for mermaid-js ready!

Name Link
🔨 Latest commit 10f9a9b
🔍 Latest deploy log https://app.netlify.com/sites/mermaid-js/deploys/672fb9de6011c40008fb53fc
😎 Deploy Preview https://deploy-preview-6043--mermaid-js.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

pkg-pr-new bot commented Nov 9, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/mermaid-js/mermaid@6043
pnpm add https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/mermaid-zenuml@6043
pnpm add https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/parser@6043
pnpm add https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/layout-elk@6043

commit: 10f9a9b

Copy link

codecov bot commented Nov 9, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 4.49%. Comparing base (c8ce416) to head (10f9a9b).

Files with missing lines Patch % Lines
packages/mermaid/src/diagrams/flowchart/flowDb.ts 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #6043   +/-   ##
=======================================
  Coverage     4.49%   4.49%           
=======================================
  Files          383     382    -1     
  Lines        53925   53915   -10     
  Branches       596     621   +25     
=======================================
  Hits          2425    2425           
+ Misses       51500   51490   -10     
Flag Coverage Δ
unit 4.49% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
packages/mermaid/src/diagrams/flowchart/flowDb.ts 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

Copy link

argos-ci bot commented Nov 9, 2024

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) ⚠️ Changes detected (Review) 3 changed Nov 9, 2024, 7:46 PM

@mnito
Copy link
Author

mnito commented Nov 9, 2024

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) ⚠️ Changes detected (Review) 3 changed Nov 9, 2024, 7:46 PM

These changes make sense based on the bug fix ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug / Error Something isn't working or is incorrect
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flowchart arrowless edges stopped working in v11
1 participant