REPL fix to print blank records #2236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CarlosFigueiraMSFT
previously approved these changes
Feb 28, 2024
There was a problem hiding this comment.
Thanks for fixing this. There is also another problem in that logic, where something like Table(Blank(), {Value:2}, {Value:3}) does not get the "special treatment for single column table named Value" which it should. Can you also update the logic on lines 122-123 to look at the field names instead of the first element of the table?
|
✅ No public API change. |
MikeStall
previously approved these changes
Feb 28, 2024
anderson-joyle
dismissed stale reviews from MikeStall and CarlosFigueiraMSFT
via
f7f4a47
|
✅ No public API change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for a small issue I found while using REPL.
Table({Value:1}, Blank())