Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new custom action to AdvancedPaste module #35950

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

sanskaarz
Copy link

Summary of the Pull Request

This pull request introduces a new custom action with a corresponding hotkey, integrated throughout the application as follows:

  • Custom Action Implementation: Added in dllmain.cpp with constants defined in AdvancedPasteConstants.h.
  • Telemetry: Integrated tracking for the custom action within trace.cpp and trace.h.
  • User Interface Enhancements: Updated MainPage.xaml with new UI elements specific to the custom action, alongside event handlers in Program.cs.
  • Helper Methods: Added necessary helper methods in CustomActionHelper.cs.

Testing:
This update was manually tested to confirm:

  • The hotkey and custom action function as intended.
  • Telemetry logs are correctly generated.
  • UI elements display and respond accurately.

PR Checklist

  • Closes: #xxx
  • Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
  • Tests: Added/updated and all pass
  • Localization: All end user facing strings can be localized
  • Dev docs: Added/updated
  • New binaries: Added on the required places
  • Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

  • Add new custom action and hotkey in dllmain.cpp
  • Define new custom action's constants in AdvancedPasteConstants.h
  • Add telemetry for new custom action in trace.cpp and trace.h
  • Add new UI elements for custom action in MainPage.xaml
  • Add event handlers for new UI elements in Program.cs
  • Add helper methods for custom action in CustomActionHelper.cs

Validation Steps Performed

All tests passed, confirming feature reliability.

* Add new custom action and hotkey in `dllmain.cpp`
* Define new custom action's constants in `AdvancedPasteConstants.h`
* Add telemetry for new custom action in `trace.cpp` and `trace.h`
* Add new UI elements for custom action in `MainPage.xaml`
* Add event handlers for new UI elements in `Program.cs`
* Add helper methods for custom action in `CustomActionHelper.cs`
@crutkas
Copy link
Member

crutkas commented Nov 15, 2024

Where is the associated issue. What does the action do

@crutkas
Copy link
Member

crutkas commented Nov 15, 2024

A PR should be very topic centralized. This feels like a like of things. Namely the history.md

@sanskaarz
Copy link
Author

Hey @crutkas, that action is for a custom action on advanced paste. Actually, I'm new to contributing, so from next time, I'll try to raise topic-specific PRs for specific issues. Thanks for making me aware of the contributing standards!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants