Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/tsc init clean #60407

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

dcavalcante
Copy link

@dcavalcante dcavalcante commented Nov 4, 2024

Fixes #46150

Proposes a custom Init option to tsc (parsed similarly to jsxOptions) that accepts a tsc --init clean parameter which outputs a tsconfig.json file without unwanted comments, while keeping the previous tsc --init working as is.

The reasoning behind this, besides implementing a requested feature, is because using a custom for --init makes more sense than treating it as a boolean, which results in tsc --init false acting as a valid call to tsc without parameters.

@typescript-bot typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Nov 4, 2024
@typescript-bot
Copy link
Collaborator

Looks like you're introducing a change to the public API surface area. If this includes breaking changes, please document them on our wiki's API Breaking Changes page.

Also, please make sure @DanielRosenwasser and @RyanCavanaugh are aware of the changes, just as a heads up.

@dcavalcante
Copy link
Author

@dcavalcante please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree

@dcavalcante
Copy link
Author

@DanielRosenwasser @RyanCavanaugh is this a possible feature?

@dcavalcante dcavalcante mentioned this pull request Nov 4, 2024
5 tasks
@RyanCavanaugh
Copy link
Member

Most recently discussed at #58420. I think we're broadly in favor of just making "clean" be the only output, but need to discuss this again to finalize the exact shape.

We are not in favor of new modes; new modes don't help anyone here.

@dcavalcante
Copy link
Author

Ops, sorry I missed that discussion 🫣

Most recently discussed at #58420. I think we're broadly in favor of just making "clean" be the only output, but need to discuss this again to finalize the exact shape.

We are not in favor of new modes; new modes don't help anyone here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tsc --init-basic
3 participants