-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/tsc init clean #60407
base: main
Are you sure you want to change the base?
Feature/tsc init clean #60407
Conversation
Looks like you're introducing a change to the public API surface area. If this includes breaking changes, please document them on our wiki's API Breaking Changes page. Also, please make sure @DanielRosenwasser and @RyanCavanaugh are aware of the changes, just as a heads up. |
@microsoft-github-policy-service agree |
@DanielRosenwasser @RyanCavanaugh is this a possible feature? |
Most recently discussed at #58420. I think we're broadly in favor of just making "clean" be the only output, but need to discuss this again to finalize the exact shape. We are not in favor of new modes; new modes don't help anyone here. |
Ops, sorry I missed that discussion 🫣
|
Fixes #46150
Proposes a custom Init option to
tsc
(parsed similarly to jsxOptions) that accepts atsc --init clean
parameter which outputs atsconfig.json
file without unwanted comments, while keeping the previoustsc --init
working as is.The reasoning behind this, besides implementing a requested feature, is because using a custom for
--init
makes more sense than treating it as a boolean, which results intsc --init false
acting as a valid call totsc
without parameters.