Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorder font stack to prefer Segoe #622

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Reorder font stack to prefer Segoe #622

wants to merge 2 commits into from

Conversation

ellynliu
Copy link
Contributor

@ellynliu ellynliu commented May 8, 2024

Task: task-487561

Link: preview-622

On Windows computers, use Segoe UI. Segoe UI is not available on Mac and Linux, so fallback to Segoe UI Variable Text. After that, fallback to the remaining fonts in the font stack.

Testing

  1. Review changes.
  2. Checkout ellyn/fonts and npm start. On Windows, you should see that the font is still Segoe UI.

Contributor checklist

  • Did you update the description of this pull request with a review link and test steps?
  • Did you submit a changeset? Changesets are required for all code changes.
  • Does your pull request implement complex UI logic (js/ts)? Consider adding an integration test to test your user flow.
  • Does your pull request add a new page to the documentation site? Add your new page for automated accessibility testing in /integration/tests/accessibility.

@ellynliu ellynliu requested a review from a team as a code owner May 8, 2024 17:41
Copy link

changeset-bot bot commented May 8, 2024

🦋 Changeset detected

Latest commit: 18fca7f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@microsoft/atlas-css Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants