-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TargetFramework awareness to NuGet detector #1266
Draft
ericstj
wants to merge
15
commits into
microsoft:main
Choose a base branch
from
ericstj:NuGetDetectorFramework
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Static field order is not predictable (metadata order) whereas static- classes are ordered by invocation order and will honor the DAG set up by our "nearest" references.
… into NuGetDetectorFramework
grvillic
reviewed
Oct 17, 2024
src/Microsoft.ComponentDetection.Detectors/nuget/FrameworkPackages/FrameworkPackages.net9.0.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.ComponentDetection.Detectors/nuget/NuGetPackagesConfigDetector.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.ComponentDetection.Detectors/nuget/FrameworkPackages/FrameworkPackages.cs
Show resolved
Hide resolved
...osoft.ComponentDetection.Detectors/nuget/NuGetProjectModelProjectCentricComponentDetector.cs
Show resolved
Hide resolved
...osoft.ComponentDetection.Detectors/nuget/NuGetProjectModelProjectCentricComponentDetector.cs
Outdated
Show resolved
Hide resolved
grvillic
reviewed
Oct 17, 2024
...osoft.ComponentDetection.Detectors/nuget/NuGetProjectModelProjectCentricComponentDetector.cs
Outdated
Show resolved
Hide resolved
grvillic
reviewed
Oct 17, 2024
...osoft.ComponentDetection.Detectors/nuget/NuGetProjectModelProjectCentricComponentDetector.cs
Show resolved
Hide resolved
… into NuGetDetectorFramework
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1266 +/- ##
=======================================
- Coverage 89.1% 89.0% -0.1%
=======================================
Files 361 374 +13
Lines 27742 28042 +300
Branches 1757 1758 +1
=======================================
+ Hits 24720 24983 +263
- Misses 2643 2678 +35
- Partials 379 381 +2 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does 3 things.
TargetFramework
to NuGet package references. This can be useful when querying component data to understand if components are used in a place where a vulnerability applies.ExcludeAssets="Runtime"
usage as a Development Dependencies.A couple notes:
Microsoft.NETCore.App
- the default shared framework. We could consider doing the same forMicrosoft.ASPNETCore.App
andMicrosoft.WindowsDesktop.App
but we'd need to plumb the reference information out of the assets file - currently that's not read and I'm not aware of a supported NuGet API for reading it (though it is present underproject/frameworks/<framework>/frameworkReferences/<name>
targetFramework
information added to thecomponent
in the ScanManifest. I noticed that development dependencies are labeled as such if all references to the component are development dependencies. If any reference is not a development dependency then the component is not labeled as a development dependency.findLastPackage
that I used to generate the sources for the framework lists - but this is just for reference. I don't intend to check this tool in.