Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.Net Agents - Support IAutoFunctionInvocationFilter for OpenAIAssistantAgent #9690

Open
wants to merge 11 commits into from
Open

.Net Agents - Support IAutoFunctionInvocationFilter for OpenAIAssistantAgent #9690

wants to merge 11 commits into from
+474 −113

Conversation

crickman
Copy link
Contributor

Motivation and Context

Fixes: #9673

Description

  • Add explicit support for IAutoFunctionInvocationFilter within run processing for OpenAIAssistantAgent
  • Verified expected behavior for IFunctionInvocationFilter
  • Added sample

Contribution Checklist

@crickman crickman added PR: in progress Under development and/or addressing feedback .NET Issue or Pull requests regarding .NET code labels Nov 13, 2024
@crickman crickman self-assigned this Nov 13, 2024
@crickman crickman requested a review from a team as a code owner November 13, 2024 19:22
@crickman crickman added bug Something isn't working experimental Associated with an experimental feature enhancement agents labels Nov 13, 2024
@markwallace-microsoft markwallace-microsoft added the kernel Issues or pull requests impacting the core kernel label Nov 13, 2024
@crickman crickman removed the request for review from markwallace-microsoft November 15, 2024 02:08
@crickman crickman removed kernel Issues or pull requests impacting the core kernel PR: in progress Under development and/or addressing feedback labels Nov 15, 2024
@markwallace-microsoft markwallace-microsoft added the kernel Issues or pull requests impacting the core kernel label Nov 15, 2024
@crickman crickman added this pull request to the merge queue Nov 15, 2024
Any commits made after this event will not be merged.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SergeyMenshykh SergeyMenshykh SergeyMenshykh approved these changes

@TaoChenOSU TaoChenOSU TaoChenOSU approved these changes

@markwallace-microsoft markwallace-microsoft Awaiting requested review from markwallace-microsoft

@alliscode alliscode Awaiting requested review from alliscode

@moonbox3 moonbox3 Awaiting requested review from moonbox3

Assignees

@crickman crickman

Labels
agents bug Something isn't working enhancement experimental Associated with an experimental feature kernel Issues or pull requests impacting the core kernel .NET Issue or Pull requests regarding .NET code
Projects
Semantic Kernel
Status: Sprint: In Review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

.Net - Bug: OpenAIAssistantAgent class IAutoFunctionInvocationFilter and IPromptRenderFilter do not work
4 participants
@crickman @TaoChenOSU @SergeyMenshykh @markwallace-microsoft