Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider readonly TestContext as valid #4053

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Consider readonly TestContext as valid #4053

wants to merge 5 commits into from

Conversation

Youssef1313
Copy link
Member

Fixes #4032

Evangelink
Evangelink reviewed Nov 15, 2024
View reviewed changes
Copy link
Member

@Evangelink Evangelink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please double check if we have a test case where we would have readonly TestContext property and no ctor accepting TestContext parameter? I think we should still raise in this case because the property would end up not being set.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Evangelink Evangelink Evangelink left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Type: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FP warning UTA031
2 participants
@Youssef1313 @Evangelink