-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
util/system: deprecate Atime implementation for containerd/continuity/fs #5465
Open
thaJeztah
wants to merge
2
commits into
moby:master
Choose a base branch
from
thaJeztah:switch_continuity
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ah, dang; probably continuity uses
|
Ah, it uses specific build-tags, has
|
thaJeztah
force-pushed
the
switch_continuity
branch
from
October 31, 2024 13:21
bacdf6a
to
5044971
Compare
github-actions
bot
added
the
area/dependencies
Pull requests that update a dependency file
label
Oct 31, 2024
thaJeztah
force-pushed
the
switch_continuity
branch
from
November 14, 2024 18:46
5044971
to
10fccbd
Compare
full diff: containerd/continuity@v0.4.4...v0.4.5 Signed-off-by: Sebastiaan van Stijn <[email protected]>
These were added in 0b5a315, because the continuity/fs package did not provide a Windows implementation. They were upstreamed in [continuity@3cbda8c], which is part of continuity v0.4.4, so we can deprecate the implementation here. [continuity@3cbda8c]: https://github.com/containerd/continuity//commit/3cbda8c24bde1ce635ff5dc3417a481a3b6b6e07 Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
switch_continuity
branch
from
November 14, 2024 21:33
10fccbd
to
195cef1
Compare
continuity v0.4.5 was tagged which now has all the changed needed; @AkihiroSuda @tonistiigi PTAL |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vendor: github.com/containerd/continuity v0.4.5
full diff: containerd/continuity@v0.4.4...v0.4.5
util/system: deprecate Atime implementation for containerd/continuity/fs
These were added in 0b5a315, because the continuity/fs package did not provide a Windows implementation. They were upstreamed in continuity@3cbda8c, which is part of continuity v0.4.4, so we can deprecate the implementation here.