Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

history: handle gracefulstop when history is active #5522

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

history: handle gracefulstop when history is active #5522

wants to merge 1 commit into from
+36 −2

Commits on Nov 15, 2024

  1. history: handle gracefulstop when history is active 

    When GracefulStop is called gRPC waits for current requests to finish
before closing. While this is generally the behavior we want, it is
not always same for the History.Listen endpoint. That endpoint is
usually open even if buildkit is not actively processing any builds,
because client may be waiting for new events.

The new logic is that if GracefulStop will happen, history will
close active listeners if there are no active builds. If there are
active builds then active listeners will be closed after all the
active builds have completed their finalizers.

Signed-off-by: Tonis Tiigi <[email protected]>
    @tonistiigi
    tonistiigi committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    c45cd8f View commit details
    Browse the repository at this point in the history