Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): bump cheerio from 1.0.0-rc.12 to 1.0.0 #5404

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

chore(deps): bump cheerio from 1.0.0-rc.12 to 1.0.0 #5404

wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Aug 12, 2024 •
edited
Loading

Bumps cheerio from 1.0.0-rc.12 to 1.0.0.

Release notes

Sourced from cheerio's releases.

v1.0.0

Cheerio 1.0 is here! 🎉

Announcement Blog Post

Breaking Changes

  • The minimum NodeJS version is now 18.17 or higher cheeriojs/cheerio#3959

  • Import paths were simplified. For example, use cheerio/slim instead of cheerio/lib/slim. cheeriojs/cheerio#3970

  • The deprecated default Cheerio instance and static methods were removed. cheeriojs/cheerio#3974

    Before, it was possible to write code like this:

    import cheerio, { html } from 'cheerio';
html(cheerio('<test></test>')); // ~ '<test></test>' -- NO LONGER WORKS

    Make sure to always load documents first:

    import * as cheerio from 'cheerio';
cheerio.load('<test></test>').html();

  • Node types previously re-exported by Cheerio must now be imported directly from (domhandler)(https://github.com/fb55/domhandler). cheeriojs/cheerio#3969

  • htmlparser2 options now reside exclusively under the xml key (cheeriojs/cheerio#2916):

    const $ = cheerio.load('<html>', {
  xml: {
    withStartIndices: true,
  },
});

New Features

Fixes

... (truncated)

Commits
  • 50b5d5c 1.0.0
  • eea2fec fix(eslint): Disable misfiring lint rule
  • e60f659 chore(package): Update published files
  • 4fe3e7b chore(docs): Add 1.0 Announcement Post (#3984)
  • 944553b build(deps): bump docusaurus-plugin-typedoc in /website (#3983)
  • e34967e build(deps-dev): bump tsx from 4.16.5 to 4.17.0 (#3982)
  • eb7122b chore(traversing): Add test case for lowerCaseTags (#3981)
  • b824ba8 fix(website): Fix ReactLiveScope examples (#3980)
  • 08ebee5 build(deps-dev): bump eslint-plugin-jsdoc from 49.0.0 to 50.0.0 (#3979)
  • bf5f44c build(deps-dev): bump eslint-plugin-jsdoc from 48.11.0 to 49.0.0 (#3976)
  • Additional commits viewable in compare view

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Aug 12, 2024
@fregante
Copy link
Contributor

You might have to wait for web-ext and addons-linter to reach v18 first

The minimum NodeJS version is now 18.17 or higher #3959

From: https://github.com/cheeriojs/cheerio/releases/tag/v1.0.0

@willdurand
Copy link
Member

@dependabot rebase

@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/cheerio-1.0.0 branch from 31c26ad to 90cf5b5 Compare September 9, 2024 09:42
@willdurand
Copy link
Member

@dependabot rebase

@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/cheerio-1.0.0 branch from 90cf5b5 to c164187 Compare September 9, 2024 09:44
@willdurand
Copy link
Member

@dependabot rebase

@dependabot
chore(deps): bump cheerio from 1.0.0-rc.12 to 1.0.0
71f0404 
Bumps [cheerio](https://github.com/cheeriojs/cheerio) from 1.0.0-rc.12 to 1.0.0.
- [Release notes](https://github.com/cheeriojs/cheerio/releases)
- [Commits](cheeriojs/cheerio@v1.0.0-rc.12...v1.0.0)

---
updated-dependencies:
- dependency-name: cheerio
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/cheerio-1.0.0 branch from c164187 to 71f0404 Compare September 9, 2024 10:11
@fregante
Copy link
Contributor

fregante commented Sep 9, 2024

Technically this shouldn’t be merged without a semver major of web-ext because it would change the minimum compatible node version. People do not use the latest 18.x minor so they will inevitably open issues when their release flows stop working.

@willdurand
Copy link
Member

Technically this shouldn’t be merged without a semver major of web-ext because it would change the minimum compatible node version. People do not use the latest 18.x minor so they will inevitably open issues when their release flows stop working.

Isn't web-ext requiring Node 18 already?

@fregante
Copy link
Contributor

Requiring Node 18 means Node 18.0, not Node 18.17, not all 18.x environments use the latest minor version so silently changing it to a x.17 will definitely break some. I caused this recently in a popular package: withastro/astro#11480 (comment)

"Minor" breaking versions in node are particularly confusing because Cheerio would work in Node 18.17 but not 19.0 nor 20.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fregante @willdurand