MNTOR-3380 - pass nimbus_preview param to Cirrus #5307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview URL 🚀 : https://blurts-server-pr-5307-mgjlpikfea-uk.a.run.app |
|
Preview URL 🚀 : https://blurts-server-pr-5307-mgjlpikfea-uk.a.run.app |
|
Preview URL 🚀 : https://blurts-server-pr-5307-mgjlpikfea-uk.a.run.app |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References:
Jira: MNTOR-3380/
Description
The Nimbus team came up with an ADR to support enabling preview mode on specific page loads. We previously had a workaround in place that would simply enable all experiments when an HTTP parameter like
?nimbus_web_preview=truewas passed, this change really just removes that and does two things:nimbus_previewThis will instruct Cirrus to check which experiments are in preview mode on the server, and only enable these.
How to test
See ticket. It's probably easiest to merge this to stage and test there, but we can at least verify locally that
nimbus_preview=trueis appended to the URL set inprocess.env.NIMBUS_SIDECAR_URL.Checklist (Definition of Done)