Implement adding secrets to vault from UI #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
December 4, 2023 17:25
Move more function to common.js Fix passing double // without subPath when making connection to vault resulting in a lot of 301 redirections. Add comments.
|
Thanks for investing effort to refactor and improve the code. If possible, please split your work into one PR that refactors and then a second PR that adds functionality. That way it's much easier for me to review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try to implement #22 .
I needed/wanted to refactor a lot to have common code paths instead of separate. The frivolous usage of global namespace and pollution of symbols will bite in the long run. I added some comments, but the code is anyway a long way from mediocre.
I added "add" page for adding passwords from the ui. The fields is filled with the first matched pattern and secrets group to ease up filling. I use only a single secrets group.
This requires testing if it works correctly for all users, if errors are properly handled. Also needs to be tested with multiple secrets directory, I use only one. Thanks.