Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix log backup file extension #5815

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix log backup file extension #5815

wants to merge 3 commits into from

Conversation

zakk616
Copy link

@zakk616 zakk616 commented Aug 21, 2024

When logfile_size_limit is used the log rotation creates new log files and renames old ones by adding a suffix:

.yyyy.mm.dd.hh.mm.ss.micros

the file extension becomes difficult to configure for compressing and archiving based on file extension using tools such as logrotate

Logs will now be backed up with an extension of .log. so these files can be compressed or moved to archiveing paths based on file extensions.

Before:

nats-server.log
nats-server.log.2024.08.21.14.37.57.558600300
nats-server.log.2024.08.21.14.40.28.743600300

After:

nats-server.log
nats-server.2024.08.21.14.37.57.558600300.log
nats-server.2024.08.21.14.40.28.743600300.log

@zakk616 zakk616 requested a review from a team as a code owner August 21, 2024 16:21
@zakk616 zakk616 mentioned this pull request Aug 25, 2024
Open
@github-actions github-actions bot added the stale This issue has had no activity in a while label Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ripienaar ripienaar Awaiting requested review from ripienaar

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
stale This issue has had no activity in a while
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@zakk616