Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use environment variables by default in module config #93

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

sinedied
Copy link
Contributor

@sinedied sinedied commented Jan 15, 2020

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

Use a default config to simplify module configuration.

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior?

Before:

    AzureStorageModule.withConfig({
      sasKey: process.env['AZURE_STORAGE_SAS_KEY'],
      accountName: process.env['AZURE_STORAGE_ACCOUNT'],
      containerName: 'nest-demo-container',
    }),

Issue Number: N/A

What is the new behavior?

After (even containerName could be omitted, but you usually want to customize it anyway):

    AzureStorageModule.withConfig({
      containerName: 'nest-demo-container',
    }),

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Also updated deps for vulnerabilities & fixed prettier formatting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant