Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(crud-typeorm): fix duplicate column names when using limit parameter #808

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zetti-caletti
Copy link

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message was generated by yarn commit
  • Tests for the changes have been added (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Tests
[ ] Release
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior?

When using limit parameter on getMany() and eager loading of nested entities the query failed because of duplicate column names. Primary columns where selected twice.

Issue Number: N/A

What is the new behavior?

Now all the column names are made unique so that no duplicate column names occur.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

When using limit parameter on getMany() and eager loading of nested
entities the query failed because of duplicate column names. Primary
columns where selected twice.
@DanielUche
Copy link

This error still persists

@streetlogics
Copy link

@michaelyali @fwoelffel @rjpkuyper - any chance one of you can take a look at this and merge / release this PR? I also have this commit merged into my fork's master with these merge conflicts resolved - streetlogics@e9dc932 . Anything to get this working would be amazing!

@afilp
Copy link

afilp commented Nov 1, 2023

@zetti-caletti This repo seems to not be supported anymore, would you like to submit your PR to the following forked repo, which is more up-to-date? Thanks!

https://github.com/gid-oss/dataui-nestjs-crud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants