fix(ir): Add support for byte format in string validation #1296
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1261
Overview
I've added a new
Byte
field to theString
structure in thevalidate
package.This field is set to true when
format: byte
is specified in the string formats of OpenAPI.When executing character length validation, if the
Byte
field is true, the length is verified using []byte instead of []rune.Note
This change may not be necessary.
According to the OpenAPI specification,
format: byte
is specified for base64-encoded characters.If the characters used are those in base64 encoding, the length evaluation doesn't change during the
[]byte -> string -> []rune
conversion process.However, as mentioned in the issue, I suppose this change is necessary if we want to ensure validation behavior for more general bytes fields.